On Jul 23, 8:59=A0am, William D Clinger <cesur...@[EMAIL PROTECTED]
> wrote:
> In tests/r6rs/io/****ts.sls, I suggest changing the last
> three calls to open-file-input/output-****t to use a
> transcoder with the latin-1-codec instead of utf-8-codec.
Done in SVN.
> The other change I suggest would reduce the code size of
> tests/r6rs/arithmetic/fixnums.sls. =A0Its large code size
> is caused by this code:
>
> =A0 =A0 ;; If you put N numbers here, it expads to N^3 tests!
> =A0 =A0 (carry-tests 0
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[0 1 2 -1 -2 38734 -3843 2484598
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 -348732487 (greatest-fixnum)
(least-f=
ixnum)])
>
> The following change would reduce those 1331 tests to
> 500 without losing much in the way of test coverage:
>
> =A0 =A0 (carry-tests 0 [0 1 2 -1 -2])
>
> =A0 =A0 (carry-tests 0 [2 -1 -2 38734 -3843])
>
> =A0 =A0 (carry-tests 0 [2 -1 -2 (greatest-fixnum) (least-fixnum)])
>
> =A0 =A0 (carry-tests 0 [-3843 2484598 -348732487
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (greatest-fixnum)
(least-fixnum)]=
)
I'm less sold on this one. Don't we want tests combining
`(greatest-fixnum)' with 0 and with 1, for example?
In fact, in SVN, I've made it worse. The `carry-tests' form was
meant to expand to tests of `fx+/carry' and `fx-/carry' in addition
to `fx*/carry'. So, now there are 3 times as many tests, instead of
1/3 as many tests. And even if I had re-organized as above, adding the
missing operators would leave us with more tests than before.
But it does seem unlikely that 3993 tests are really necessary.
Any ideas that will shrink the set of tests enough, even with the
added operators?
Thanks,
Matthew
|
